On Thu, Feb 23, 2023 at 6:20 AM Derrick Stolee <derrickstolee@xxxxxxxxxx> wrote: > > On 2/23/2023 3:05 AM, Elijah Newren via GitGitGadget wrote: > > From: Elijah Newren <newren@xxxxxxxxx> > > > > Move struct object_info, and a few related #define's from cache.h to > > object-store.h. > > > diff --git a/replace-object.h b/replace-object.h > > index 3fbc32eb7b7..3c92ae94610 100644 > > --- a/replace-object.h > > +++ b/replace-object.h > > @@ -1,6 +1,7 @@ > > #ifndef REPLACE_OBJECT_H > > #define REPLACE_OBJECT_H > > > > +#include "cache.h" > > #include "oidmap.h" > > #include "repository.h" > > #include "object-store.h" > > This seems like an unlikely side-effect of the changes you're > making. What is the reason we need this? I'll add the following to the commit message: A surprising effect of this change is that replace-object.h, which includes object-store.h, now needs to directly include cache.h since that is where read_replace_refs is declared and that variable is used in one of its inline functions. The next commit will move that declaration and fix that unfortunate new direct inclusion of cache.h.
