Alex Henrie <alexhenrie24@xxxxxxxxx> writes: > Signed-off-by: Alex Henrie <alexhenrie24@xxxxxxxxx> > --- No cover letter to summarize the changes? Comparing this round with the previous, the only two changes are that [1/3] lost one test "do not rebase merges unless asked to", and [2/3] now uses test_must_fail to mark a git command that is expected to stop. Looks good, but a rerolled patch series should not force reviewers to fetch and compare, but give a summary of changes when it is sent out, to save everybody's time. Preparing a summary before sending it out also helps the patch author, too, that all the intended changes are included in the new round. Thanks.
