On 2/23/2023 3:05 AM, Elijah Newren via GitGitGadget wrote: > From: Elijah Newren <newren@xxxxxxxxx> > > Since git-compat-util.h needs to be included first in C files, having it > appear in header files is unnecessary. More importantly, having it > included in header files seems to lead to folks leaving it out of C > files, which makes it harder to verify that the rule is being followed. > Remove it from header files, other than the ones that have been approved > as alternate first includes. ... > compat/fsmonitor/fsm-ipc-win32.c | 1 + > compat/fsmonitor/fsm-settings-darwin.c | 1 + It looks like you have a couple .c files here that belong in the previous patch. Thanks, -Stolee
