On Wed, Feb 22, 2023 at 4:56 PM Junio C Hamano <gitster@xxxxxxxxx> wrote: > > Alex Henrie <alexhenrie24@xxxxxxxxx> writes: > > > +test_expect_success '--rebase-merges="" is invalid syntax' ' > > + echo "fatal: Unknown mode: " >expect && > > + ! git rebase --rebase-merges="" HEAD^ 2>actual && > > "!" takes any non-zero exit, even a segfaulting "git". Let's use > test_must_fail to make sure it dies in a controlled way, i.e. > > test_must_fail git rebase --rebase-merges="" HEAD^ 2>actual && Done in v4. Thanks for the feedback. -Alex
