On Tue, Feb 21, 2023 at 11:36 AM John Cai <johncai86@xxxxxxxxx> wrote: > > On 21 Feb 2023, at 13:51, Junio C Hamano wrote: > > > Elijah Newren <newren@xxxxxxxxx> writes: > > > >> I'll leave that up to you and John, but are we risking merging code > >> that could go unused or that we need to fundamentally change? I don't > >> see how to handle the issues over at > >> https://lore.kernel.org/git/647D3D49-B85B-4B66-A857-695CFF9685EE@xxxxxxxxx/ > > > > If this is useful enough for desktop users already, then that is a > > good enough reason to take it, I would say. > > > > GitLab can easily add WebUI that says "You can define what diff > > algorithm is used for files with which suffix" to allow you to > > configure a table like this: > > > > json | histogram > > c | patience > > * | myers > > > > and populate the server-side equivalent of .git/info/attributes and > > .git/config based on that, and without anything further than the > > posted patches, the result should just work, no? > > Yes, that is my thinking too. The goal was to make this user friendly for > everyone on the Git command line, and then GitLab can hook into this accordingly > to make it ussable with the GitLab UI. Ok, sounds good. Merge away. :-)
