On Thu, Feb 16, 2023 at 01:49:55PM -0500, Jeff King wrote: > Thanks for following up on this. I think it's an obviously good > direction, and the patch looks sensible. It's hard to grep for > --follow-symlinks or FOLLOW_SYMLINKS to make sure you got everything, > just because there are other unrelated features that use that name. ;) No problem. > But...that is true even before your patch. dir5 is not mentioned in any > of the expected output, even in fa1da7d2ee (dir-iterator: add flags > parameter to dir_iterator_begin, 2019-07-10) where it was added. Was it > just vestigial? Or is it somehow important that it is _not_ in the > output? > > I didn't dig, and even if it can be removed, it would probably make > sense to do it separately from your patch anyway. I have no idea either. From a cursory scan, I think I'd err on the side of it being vestigial. But Matheus (cc'd) should be able to tell us for sure. Thanks, Taylor
