On Wed, Feb 15, 2023 at 06:56:14PM -0800, Junio C Hamano wrote: > This test helper feeds 256kB of data at once to a single invocation > of the write(2) system call, which may be too much for some > platforms. > > Call our xwrite() wrapper that knows to honor MAX_IO_SIZE limit and > cope with short writes due to EINTR instead, and die a bit more > loudly by calling die_errno() when xwrite() indicates an error. Thanks, this looks good to me. > I ended up avoiding write_or_die() primarily because there is > nothing "Git" about this helper, which is a poor-man's emulation > of "dd if=/dev/zero". It felt a bit too much to pull cache.h in > as dependency for it. I don't find it any more "Git" than xwrite() or die_errno(), really, but I am quite happy with what you have here. -Peff
