Rubén Justo <rjusto@xxxxxxxxx> writes: > ... If the tests fail, I think it will be easier and > less confusing to reach the original commit where the implementation was > done if we keep them separated, rather than combining all three commits. No, if the test were in the same commit as the implementation, then upon a future test breakage it is easier to see what code the test was meant to protect, exactly because it is part of the same commit. > I'm going to reorder the commits and change to use test_expect_failure(). Do not do that. Adding a failing test and flipping the expect_failure to expect_success is a sure way to make the series harder to review.
