Are there any cases where a taggerdate heuristic would be useful now? I'm having a hard time coming up with an example of such, so this change looks very reasonable to me. Even if there existed such a case, I would imagine it would be better solved using other heuristics rather than checking the taggerdate since that was a very loose heuristic to begin with. > diff --git a/builtin/name-rev.c b/builtin/name-rev.c > index 15535e914a6..df50abcdeb9 100644 > --- a/builtin/name-rev.c > +++ b/builtin/name-rev.c > @@ -113,9 +113,7 @@ static int is_better_name(struct rev_name *name, > * based on the older tag, even if it is farther away. > */ > if (from_tag && name->from_tag) > - return (name->taggerdate > taggerdate || > - (name->taggerdate == taggerdate && > - name_distance > new_distance)); > + return name_distance > new_distance; Comment above this block should be updated to match the new logic. -Calvin
