Hi Ævar On 06/02/2023 22:58, Ævar Arnfjörð Bjarmason wrote:
We've given the "git add -i" migration away from Perl to a built-in enough time to remove the old Perl code. For v1, see: https://lore.kernel.org/git/cover-0.3-00000000000-20230203T125859Z-avarab@xxxxxxxxx/ Branch & CI for this at: https://github.com/avar/git/tree/avar/nuke-perl-add--interactive-2 The only change from v1 is to squash in a suggested change from Philippe Blain, thanks!
Thanks for doing this, it will be nice to only have a single implementation to worry about.
Best Wishes Phillip
Ævar Arnfjörð Bjarmason (3): add: remove "add.interactive.useBuiltin" & Perl "git add--interactive" add API: remove run_add_interactive() wrapper function docs & comments: replace mentions of "git-add--interactive.perl" .gitignore | 1 - Documentation/config/add.txt | 7 +- Documentation/git-add.txt | 6 +- INSTALL | 2 +- Makefile | 1 - builtin/add.c | 61 +- builtin/checkout.c | 12 +- builtin/clean.c | 2 +- builtin/reset.c | 4 +- builtin/stash.c | 3 +- ci/run-build-and-tests.sh | 1 - commit.h | 2 - git-add--interactive.perl | 1920 ---------------------------------- pathspec.c | 2 +- t/README | 4 - t/t2016-checkout-patch.sh | 6 - t/t3701-add-interactive.sh | 29 +- t/t6132-pathspec-exclude.sh | 6 +- t/test-lib.sh | 4 - 19 files changed, 50 insertions(+), 2023 deletions(-) delete mode 100755 git-add--interactive.perl Range-diff against v1: 1: f39dde93011 ! 1: 71c7922b25f add: remove "add.interactive.useBuiltin" & Perl "git add--interactive" @@ Documentation/config/add.txt: add.ignore-errors (deprecated):: + interactive mode, which then became the default in Git + versions v2.37.0 to v2.39.0.+ ## INSTALL ##+@@ INSTALL: Issues of note: + for everyday use (e.g. "bisect", "request-pull"). + + - "Perl" version 5.8 or later is needed to use some of the +- features (e.g. preparing a partial commit using "git add -i/-p", ++ features (e.g. sending patches using "git send-email", + interacting with svn repositories with "git svn"). If you can + live without these, use NO_PERL. Note that recent releases of + Redhat/Fedora are reported to ship Perl binary package with some + ## Makefile ## @@ Makefile: SCRIPT_LIB += git-mergetool--lib SCRIPT_LIB += git-sh-i18n 2: fb0dafaf4a4 = 2: 9299f22cc2c add API: remove run_add_interactive() wrapper function 3: 6ee56de1371 = 3: 09bece75c22 docs & comments: replace mentions of "git-add--interactive.perl"
