Hi, Eric On Sun, Feb 5, 2023 at 3:30 PM Eric Sunshine <sunshine@xxxxxxxxxxxxxx> wrote: > This probably ought to say "indent with tab" since that's what this > patch is doing. Thanks ,I will fix it . > If you do find a reason to re-roll, though, I might suggest swapping > patches 2 and 3 since the current organization leaves a mix of tab and > space indentation in the tests, which makes reviewers do extra work > since they have to look ahead in the patch series to see if you fix > the inconsistent indentation in a later patch. Yeah ,I didn‘t realize that .Thanks for reply! I will send the V4 soon. ---------- Thanks, Shuqi
