On Sat, Feb 4, 2023 at 3:54 PM Kostya Farber <kostya.farber@xxxxxxxxx> wrote: > To match present day coding guiding codelines let's: We can probably just say "coding guidelines" rather than "coding guiding codelines". > - use <<-EOF, so we can indent all lines to the > the same level for this test > > - use <<\EOF to notify the reader that no interpolation > is exepected in the body s/exepected/expected/ > Signed-off-by: Kostya Farber <kostya.farber@xxxxxxxxx> > --- For other reviewers who may not have been following along, this is a suggested replacement[1] to a rejected (by me[2]) GSoC microproject[3]. > diff --git a/t/t5000-tar-tree.sh b/t/t5000-tar-tree.sh > @@ -402,11 +402,11 @@ test_expect_success GZIP 'extract tgz file (external gzip)' ' > test_expect_success 'archive and :(glob)' ' > git archive -v HEAD -- ":(glob)**/sh" >/dev/null 2>actual && > - cat >expect <<EOF && > -a/ > -a/bin/ > -a/bin/sh > -EOF > + cat >expect <<-\EOF && > + a/ > + a/bin/ > + a/bin/sh > + EOF > test_cmp expect actual > ' Thanks, these changes look fine. [1]: https://lore.kernel.org/git/CAPig+cR+1bxgitSmJ47PxD=CPxJjMh5Vm+zRdVU8iEo9pvtutw@xxxxxxxxxxxxxx/ [2]: https://lore.kernel.org/git/CAPig+cTC4TUK2NXFmP6ymEYYjYAmCSd53dzFhKn0ido8x6uh1Q@xxxxxxxxxxxxxx/ [3]: https://lore.kernel.org/git/20230202202557.19297-1-kostya.farber@xxxxxxxxx/
