On Thu, Feb 2, 2023 at 4:10 PM Junio C Hamano <gitster@xxxxxxxxx> wrote: > Good, but end the sentence with a full-top with a space after it, > and start the next sentence with a capital letter. Sure, think I need to change it to " ...space. Fix..". I will pay more attention to my English written style. > This is not wrong per se, but the modern style is to avoid having > any executable lines outside test_expect_foo. I'd expect that the > resulting script begins more like the attached. [PATCH 4/4] stops > the conversion in the middle, which leaves funny taste in our mouth. Thanks, Will avoid having any executable lines outside test_expect_foo. Overall, thanks for the reply and it is really helpful! -------------------------------- Shuqi
