Hi Harshil, On Thu, 2 Feb 2023, Harshil Jani via GitGitGadget wrote: > Range-diff vs v1: > > 1: bc79dfcc4d4 = 1: bc79dfcc4d4 mingw: remove duplicate `USE_NED_ALLOCATOR` directive > 2: e6d3d280a4f ! 2: 0c0289343fb mingw: remove msysGit/MSYS1 support > @@ Metadata > ## Commit message ## > mingw: remove msysGit/MSYS1 support > > - The msysGit (i.e. Git for Windows 1.x' SDK) is no longer used and the > - last known user for MSys1 + MinGW has switched to MSys2. So there was no > - reason to keep the msysGit/MSys1 config section. This Patch intends to > - remove the support of both the builds and throw an error on > - execution. > - > - The output of `uname -r` if returns us with '1.' then it relates with MSys1 > - build environment and msysGit which we don't want to continue ahead and thus > - an error can be expected. > - > - The MSYS2 is currently used into the MinGW so we can get that part > - running directly without any conditionals required. > + MSys has long fallen behind MSYS2 in features like Unicode or > + x86_64 support or even security bug fixes, and is therefore no > + longer used by anyone in the Git developer community. The Git for > + Windows project itself started switching from MSys to MSYS2 early > + in 2015, i.e. about eight years ago. Let's drop supporting MSys as > + a development platform. > > Signed-off-by: Harshil-Jani <harshiljani2002@xxxxxxxxx> This seems to address Junio's concern. I'm fine with these patches, too. Here's my ACK. Ciao, Johannes
