Re: [PATCH 5/5] format-patch: Add support for --{to,cc}-cmd flags

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Zev Weiss <zev@xxxxxxxxxxxxxxxxx> writes:
> Having these flags available for format-patch instead of only on
> send-email makes it much easier to use an automated command to do the
> bulk of the recipient-selection work but still manually adjust it if
> desired.

Commit message could use some more explanation to make blame diving
easier later on. In particular, why is creating temp files necessary? 

Missing update to Documentation/git-format-patch.txt

This patch also needs many more tests
 - tests for --cc-cmd
 - tests for commands that run on the patches
 - similar tests in t9001-send-email.sh

Will wait for reroll to dive deeper into the implementation here, but
overall a well-intentioned v1!



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux