Re: Bug: Cloning git repositories behind a proxy using the git:// protocol broken since 2.32

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2023-01-31 at 12:31 -0800, Jacob Keller wrote:
> On Tue, Jan 31, 2023 at 4:17 AM Florian Bezdeka
> <florian.bezdeka@xxxxxxxxxxx> wrote:
> > Thanks for the super fast response, highly appreciated!
> > 
> > I was able to get it running by switching to ncat using the --no-
> > shutdown option, but I failed to bring back socat support so far.
> > 
> > For me this is still a regression. We have to change our
> > infrastructure/environment because we have a new requirement
> > (independent handling of stdin/out) after updating git now. I would
> > expect some noise from the yocto/OE community in the future where oe-
> > git-proxy is heavily used.
> > 
> > I guess proxy support was forgotten when the referenced change was
> > made. Any chance we can avoid closing stdout when running "in proxy
> > mode" to restore backward compatibility?
> > 
> > Thanks a lot!
> 
> I had this issue in the past and i got it working with socat using "-t
> 10". You need a timeout that is larger than the keep alive value of 5
> seconds which is sent by the git protocol.
> 
> Junio pointed out the excellent analysis from Peff regarding the
> situation and the fact that socat is wrong here.

Thanks for pointing me to the old discussion. I was quite sure that I'm
not the first one facing this problem but couldn't find something.

It might be that socat is doing something wrong. But git is the
component that triggers the problem. Did someone talk to the socat
maintainers yet?

Peff also mentioned that the half-duplex shutdown of the socket is
inconsistent between proxy and raw TCP git://. It seems still a valid
option to skip the half-shutdown for the git:// proxy scenario.

> 
> What value of -t did you try?

I was playing with -t 10 and -t 60 so far. Both does not work for
cloning a kernel stable tree. I guess it's hard to find a value that
works under all circumstances as timings might be different depending
on server/network speed.





[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux