Re: [PATCH v2] grep: fall back to interpreter if JIT memory allocation fails

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH v2] grep: fall back to interpreter if JIT memory allocation fails
From: Junio C Hamano <gitster@xxxxxxxxx>
Date: Mon, 30 Jan 2023 15:27:28 -0800
Cc: Mathias Krause <minipli@xxxxxxxxxxxxxx>, git@xxxxxxxxxxxxxxx, Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx>, Carlo Marcelo Arenas Belón <carenas@xxxxxxxxx>
In-reply-to: <55c75313-79d4-1c5b-951b-5d1e75553441@ramsayjones.plus.com> (Ramsay Jones's message of "Mon, 30 Jan 2023 22:30:12 +0000")
References: <20221216121557.30714-1-minipli@grsecurity.net> <20230127154952.485913-1-minipli@grsecurity.net> <xmqqbkmk9bsn.fsf@gitster.g> <xmqq1qnfancf.fsf@gitster.g> <adb5a43a-5081-4f60-d1ea-2a6511f858c0@grsecurity.net> <xmqqk0156z55.fsf@gitster.g> <9b5a1113-84f1-1651-bffc-6382462057dd@grsecurity.net> <xmqq357r4zvk.fsf@gitster.g> <xmqqlelj3hvk.fsf@gitster.g> <xmqqk0131zxi.fsf@gitster.g> <55c75313-79d4-1c5b-951b-5d1e75553441@ramsayjones.plus.com>
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux)

Ramsay Jones <ramsay@xxxxxxxxxxxxxxxxxxxx> writes:

>> +			die("Couldn't JIT the PCRE2 pattern '%s', got '%d'%s",
>> +			    p->pattern, jitret,
>> +			    pcre2_jit_functional() 
>> +			    ? "\nPerhaps prefix (*NO_GIT) to your pattern?" 
>
> s/NO_GIT/NO_JIT/ ? :)

Indeed.  Thanks.

References:
- [PATCH] grep: fall back to interpreter mode if JIT fails
  - From: Mathias Krause
- [PATCH v2] grep: fall back to interpreter if JIT memory allocation fails
  - From: Mathias Krause
- Re: [PATCH v2] grep: fall back to interpreter if JIT memory allocation fails
  - From: Junio C Hamano
- Re: [PATCH v2] grep: fall back to interpreter if JIT memory allocation fails
  - From: Junio C Hamano
- Re: [PATCH v2] grep: fall back to interpreter if JIT memory allocation fails
  - From: Mathias Krause
- Re: [PATCH v2] grep: fall back to interpreter if JIT memory allocation fails
  - From: Junio C Hamano
- Re: [PATCH v2] grep: fall back to interpreter if JIT memory allocation fails
  - From: Mathias Krause
- Re: [PATCH v2] grep: fall back to interpreter if JIT memory allocation fails
  - From: Junio C Hamano
- Re: [PATCH v2] grep: fall back to interpreter if JIT memory allocation fails
  - From: Junio C Hamano
- Re: [PATCH v2] grep: fall back to interpreter if JIT memory allocation fails
  - From: Junio C Hamano
- Re: [PATCH v2] grep: fall back to interpreter if JIT memory allocation fails
  - From: Ramsay Jones

Prev by Date: Re: What's cooking in git.git (Jan 2023, #07; Mon, 30)
Next by Date: Stability of git-archive, breaking (?) the Github universe, and a possible solution
Previous by thread: Re: [PATCH v2] grep: fall back to interpreter if JIT memory allocation fails
Next by thread: Re: [PATCH v2] grep: fall back to interpreter if JIT memory allocation fails
Index(es):
- Date
- Thread

[Index of Archives] [Linux Kernel Development] [Gcc Help] [IETF Annouce] [DCCP] [Netdev] [Networking] [Security] [V4L] [Bugtraq] [Yosemite] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Linux SCSI] [Fedora Users]