Derrick Stolee <derrickstolee@xxxxxxxxxx> writes: > I think there are two possible directions we can have when talking > about interrupted downloads: > > 1. The network connection was disconnected, and the client may want > to respond to that with a retry and a ranged request. > > 2. The client process itself terminates for some reason, and a > second process recognizes that some of the data already exists > and could be used for a range request of the remainder. > > I think both of these would not be handled at this layer, but > instead further down, inside fetch_bundle_uri_internal() > (specifically further down in download_https_uri_to_file()). > > Any retry logic should happen there, closer to the connection, > and at the layer of the current patch, we should assume that any > retry logic that was attempted ended up failing in the end. > > Does that satisfy your concerns here? Mostly. We probably do not want / need to cater to "I killed it with ^C and would want to continue". Thanks.
