On 1/27/2023 2:21 PM, Victoria Dye wrote:
> Derrick Stolee via GitGitGadget wrote:
>> From: Derrick Stolee <derrickstolee@xxxxxxxxxx>
>> + # Only base bundle unbundled.
>> + git -C download-2 for-each-ref --format="%(refname)" "refs/bundles/*" >refs &&
>> + cat >expect <<-EOF &&
>> + refs/bundles/base
>> + refs/bundles/right
>> + EOF
>> + test_cmp expect refs &&
>
> Maybe I'm misreading, but I don't think the comment ("Only base bundle
> unbundled") lines up with the expected bundle refs (both bundle-1
> ('refs/bundles/base') and bundle-3 ('refs/bundles/right') seem to be
> unbundled).
>> + # All bundles failed to unbundle
>> + git -C download-3 for-each-ref --format="%(refname)" "refs/bundles/*" >refs &&
>> + cat >expect <<-EOF &&
>> + refs/bundles/base
>> + refs/bundles/left
>> + refs/bundles/right
>> + EOF
>> + test_cmp expect refs
>
> Similar issue with the comment here - it says that all bundles *failed* to
> unbundle, but the test case description ("Case 3: top bundle does not exist,
> rest unbundle fine.") and the result show bundle-1, bundle-2, and bundle-3
> all unbundling successfully.
Thank you for reading carefully. I'm sorry about not updating
the comments after copying these checks around the test file.
Thanks,
-Stolee
