Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> writes: > Remove code that's been unused since it was added in > c553c72eed6 (run-command: add an asynchronous parallel child > processor, 2015-12-15), the next use of "i" in this function is: > > for (i = 0; ... And it has been updated to a different type, i.e. for (size_t i = 0; ... so it doubly makes sense to kill that unused variable. Makes sense. > So we'll always clobber the "i" that's set here. Presumably the "i" > assignment is an artifact of WIP code that made it into our tree. > > A subsequent commit will need to adjust the type of the "i" variable > in the otherwise unrelated for-loop, which is why this is being > removed now. That, together with the earlier mention of the other i (which I think came from the same source---perhaps the original topic this was taken from had int->size_t change in it) are both stale. Please proofread what you send out before submitting. Thanks.
