On Fri, Jan 20, 2023 at 8:16 AM Junio C Hamano <gitster@xxxxxxxxx> wrote: > > Elijah Newren <newren@xxxxxxxxx> writes: > > > On Fri, Jan 20, 2023 at 4:05 AM Junio C Hamano <gitster@xxxxxxxxx> wrote: > >> ... > >> That is, even when a patch does not cleanly apply with full context > >> in the incoming diff, by requiring *smaller* number of lines to > >> match, the diff *could* be forced to apply with reduced precision? > > > > Oh! Reducing the number of lines of context to pay attention to never > > even occurred to me for whatever reason. I'll drop the patch. > > Yup. "completely useless" on the title is less than half correct, > but still correct for a minor use case where -C is used to use > *more* context lines than the default. > > We could update "rebase --apply" codepath to increase the context > lines generated by format-patch. That would make the "completely > useless" totally incorrect ;-) haha :-) I'd probably go for that, but since in my mind the plan is still to deprecate and remove the apply backend as you suggested at [1], I'm not particularly motivated to improve/extend options specific to the apply backend of rebase. [1] https://lore.kernel.org/git/xmqqa78d2qmk.fsf@xxxxxxxxxxxxxxxxxxxxxxxxx/
