On 1/19/2023 3:34 PM, Victoria Dye wrote:
> Derrick Stolee via GitGitGadget wrote:
>> + if (!git_config_get_string_tmp("fetch.bundleuri", &bundle_uri) &&
>> + !starts_with(bundle_uri, "remote:")) {
>
> Maybe a silly question, by why would the bundle URI start with 'remote:'
> (and why do we silently skip fetching from the URI in that case)?
Thanks for catching this. I originally was going to include fetching from
lists advertised by a Git remote, and use the same `fetch.bundleURI` config.
However, it makes more sense to make a `remote.<name>.bundles` config
instead, so I dropped that functionality from this series. I forgot to remove
this `remote:` case, but will do so in v2.
I've locally fixed the "objects" typo you pointed out, too.
Thanks,
-Stolee
