On 19-ene-2023 10:48:27, Phillip Wood wrote: > I'm afraid I'm still not totally clear from this message exactly what the > problem is. Having looked at die_if_checked_out() I think it maybe the I'm going to reroll, I hope it makes sense then. > If that is the problem you're trying to solve I think it would be better to > keep the signature of find_shared_symref() the same and add a helper > function that is called by die_if_checked_out() and find_shared_symref() OK. > which can optionally ignore the current worktree. The commit message for > such a patch should explain you're fixing a bug rather than trying to change > the existing behavior. > Yes, the message is not clear that the commit is fixing a bug. I'll add that. Thank you.
