Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> writes: > There were no tests checking for the output of the git_die_config() > function in the config API, added in 5a80e97c827 (config: add > `git_die_config()` to the config-set API, 2014-08-07). We only tested > "test_must_fail", but didn't assert the output. It wasn't immediately obvious to me why this was relevant to this series; but reading ahead to 5/9 shows that git_die_config() is a caller of a *_get_value_multi() function that we are changing, so we want to assert on the output so that we know that git_die_config() is still doing the right thing (since test_must_fail alone won't tell us whether we introduced bugs in git_die_config()). Might be good to include that extra context, but I don't feel strongly about it.
