On 2023-01-17 02:31, Junio C Hamano wrote: > Luben Tuikov <luben.tuikov@xxxxxxx> writes: > >>> +test_expect_success $PREREQ "--validate hook supports header argument" ' >>> + write_script my-hooks/sendemail-validate <<-\EOF && >>> + if test -s "$2" >>> + then >>> + cat "$2" >actual >>> + exit 1 >>> + fi >>> + EOF > > If "$2" is not given, or an empty "$2" is given, is that an error? > I am wondering if the lack of "else" clause (and the hook exits with > success when "$2" is an empty file) here is intentional. I think we'll always have a $2, since it is the SMTP envelope and headers. For the rest of the comments, I'll let Michael address them. -- Regards, Luben
