Hi,
On Tue, 16 Oct 2007, Ren? Scharfe wrote:
> Pierre Habouzit schrieb:
> > This bit is to allow to aggregate options with arguments together when
> > the argument is numeric.
> >
> > +#if 0
> > + /* can be used to understand -A1B1 like -A1 -B1 */
> > + if (flag & OPT_SHORT && opt->opt && isdigit(*opt->opt)) {
> > + *(int *)opt->value = strtol(opt->opt, (char **)&opt->opt, 10);
> > + return 0;
> > + }
> > +#endif
>
> I don't like it, it complicates number options with unit suffixes (e.g.
> --windows-memory of git-pack-objects).
Why? It only means that you cannot say -W10mxabc instead of -W10m xabc.
Remember: this is a special case for OPT_INTEGER. Nothing to do with
OPT_SIZE, which you'd probably implement as a callback.
Ciao,
Dscho
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
