On Sun, Jan 15, 2023 at 3:59 PM Eric Sunshine <sunshine@xxxxxxxxxxxxxx> wrote:
> On Wed, Jan 11, 2023 at 9:48 PM Teng Long <dyroneteng@xxxxxxxxx> wrote:
> > - } else {
> > - fprintf(stderr, _("Removing note for object %s\n"),
> > - oid_to_hex(&object));
> > - remove_note(t, object.hash);
> > - logmsg = xstrfmt("Notes removed by 'git notes %s'", argv[0]);
> > + commit_notes(the_repository, t, logmsg);
> > }
> > - commit_notes(the_repository, t, logmsg);
>
> This change breaks removal of notes using "git notes edit". Prior to
> this change, if you delete the content of a note using "git notes
> edit", then the note is removed. Following this change, the note
> remains, which contradicts documented[1] behavior.
Aside from suggesting that this patch ought to be dropped, implicit in
the above comment is that test coverage is not as thorough as it
should be, otherwise this regression would have been caught early.
This suggests that the test coverage, at least for "git notes edit",
needs some beefing up, though doing so is probably outside the scope
of this series; it's something which could/should be done separately,
and it doesn't necessarily need to be done by you.
