On Thu, Jan 12 2023, Jeff King wrote: > On Thu, Jan 12, 2023 at 10:13:20AM +0100, Ævar Arnfjörð Bjarmason wrote: > >> >> On Sat, Jan 07 2023, Jeff King wrote: >> >> > + oi.typep = type; >> > + oi.sizep = size; >> > + oi.contentp = &data; >> > + if (lookup_replace) >> > + flags |= OBJECT_INFO_LOOKUP_REPLACE; >> > + if (oid_object_info_extended(r, oid, &oi, flags)) >> > + return NULL; >> >> Style: This is "\t ", but should be "\t\t". > > Hmph, I'm not sure how I managed that. Thanks for pointing it out. The > commit is in 'next', so I think we'd want this on top (of > jk/read-object-cleanup). > -- >8 -- > Subject: [PATCH] object-file: fix indent-with-space > > Commit b25562e63f (object-file: inline calls to read_object(), > 2023-01-07) accidentally indented a conditional block with spaces > instead of a tab. > > Reported-by: Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> > Signed-off-by: Jeff King <peff@xxxxxxxx> > --- > object-file.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/object-file.c b/object-file.c > index 80b08fc389..ce9efae994 100644 > --- a/object-file.c > +++ b/object-file.c > @@ -1708,7 +1708,7 @@ void *repo_read_object_file(struct repository *r, > oi.sizep = size; > oi.contentp = &data; > if (oid_object_info_extended(r, oid, &oi, flags)) > - return NULL; > + return NULL; > > return data; > } Thanks, I didn't notice (assuming it was too soon, it being less than a week) that it was in "next" already. This change LGTM, thanks!
