On Thu, Jan 12 2023, Teng Long wrote: > From: Teng Long <dyroneteng@xxxxxxxxx> > > In t3104-ls-tree-format.sh, There is a legacy 'shift 2' code > and the relevant code block no longer depends on it anymore, > so let's remove it for a small cleanup. Like with 6/6, we can do without an update for this, but if you're updating I'd say something like this instead: The "shift 2" added here when these tests were added in 455923e0a15 (ls-tree: introduce "--format" option, 2022-03-23) has never been need. Let's remove it, as we're not in the habit of clearing arguments from "$@" unless we need to use "$@" itself (or "$*") later. FWIW I think this dates back to my https://lore.kernel.org/git/RFC-patch-6.7-eac299f06ff-20211217T131635Z-avarab@xxxxxxxxx/; where there was no reason to do it either. I wouldn't normally "shift" for no reason, so it probably dates back to some earlier version where I used "$@", which didn't make it to the list. > Signed-off-by: Teng Long <dyroneteng@xxxxxxxxx> > --- > t/t3104-ls-tree-format.sh | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/t/t3104-ls-tree-format.sh b/t/t3104-ls-tree-format.sh > index 383896667b6..74053978f49 100755 > --- a/t/t3104-ls-tree-format.sh > +++ b/t/t3104-ls-tree-format.sh > @@ -20,7 +20,6 @@ test_ls_tree_format () { > format=$1 && > opts=$2 && > fmtopts=$3 && > - shift 2 && > > test_expect_success "ls-tree '--format=<$format>' is like options '$opts $fmtopts'" ' > git ls-tree $opts -r HEAD >expect &&
