A hopefully final version of this collection of simple leak fixes. See https://lore.kernel.org/git/cover-v2-00.20-00000000000-20221230T020341Z-avarab@xxxxxxxxx/ for v2. Changes since v2: * Updated reference to function name in a commit subject, spotted by René. * Dropped a patch that didn't fix a leak, but just did a post-cleanup of an already fixed leak. Ævar Arnfjörð Bjarmason (19): tests: mark tests as passing with SANITIZE=leak bundle.c: don't leak the "args" in the "struct child_process" commit-graph: use free_commit_graph() instead of UNLEAK() clone: use free() instead of UNLEAK() various: add missing clear_pathspec(), fix leaks name-rev: don't xstrdup() an already dup'd string repack: fix leaks on error with "goto cleanup" worktree: fix a trivial leak in prune_worktrees() http-backend.c: fix "dir" and "cmd_arg" leaks in cmd_main() http-backend.c: fix cmd_main() memory leak, refactor reg{exec,free}() commit-graph: fix a parse_options_concat() leak show-branch: free() allocated "head" before return builtin/merge.c: always free "struct strbuf msg" builtin/merge.c: free "&buf" on "Your local changes..." error object-file.c: release the "tag" in check_tag() grep.c: refactor free_grep_patterns() grep API: plug memory leaks by freeing "header_list" receive-pack: free() the "ref_name" in "struct command" push: free_refs() the "local_refs" in set_refspecs() archive.c | 1 + builtin/clean.c | 1 + builtin/clone.c | 5 +++-- builtin/commit-graph.c | 10 ++++++---- builtin/merge.c | 14 ++++++------- builtin/name-rev.c | 23 ++++++++++------------ builtin/push.c | 1 + builtin/receive-pack.c | 10 ++++++++++ builtin/repack.c | 13 ++++++------ builtin/reset.c | 11 ++++++++--- builtin/show-branch.c | 1 + builtin/stash.c | 7 +++++-- builtin/worktree.c | 6 +++--- bundle.c | 6 ++++-- grep.c | 15 +++++++++----- http-backend.c | 9 +++++++-- object-file.c | 1 + t/t0023-crlf-am.sh | 1 + t/t1301-shared-repo.sh | 1 + t/t1302-repo-version.sh | 1 + t/t1304-default-acl.sh | 1 + t/t1408-packed-refs.sh | 1 + t/t1410-reflog.sh | 1 + t/t1416-ref-transaction-hooks.sh | 1 + t/t2401-worktree-prune.sh | 1 + t/t2406-worktree-repair.sh | 1 + t/t3210-pack-refs.sh | 1 + t/t3800-mktag.sh | 1 + t/t4152-am-subjects.sh | 2 ++ t/t4254-am-corrupt.sh | 2 ++ t/t4256-am-format-flowed.sh | 1 + t/t4257-am-interactive.sh | 2 ++ t/t5001-archive-attr.sh | 1 + t/t5004-archive-corner-cases.sh | 2 ++ t/t5302-pack-index.sh | 2 ++ t/t5317-pack-objects-filter-objects.sh | 1 + t/t5330-no-lazy-fetch-with-commit-graph.sh | 1 + t/t5403-post-checkout-hook.sh | 1 + t/t5405-send-pack-rewind.sh | 1 + t/t5406-remote-rejects.sh | 1 + t/t5502-quickfetch.sh | 1 + t/t5504-fetch-receive-strict.sh | 1 + t/t5507-remote-environment.sh | 2 ++ t/t5522-pull-symlink.sh | 1 + t/t5523-push-upstream.sh | 1 + t/t5527-fetch-odd-refs.sh | 1 + t/t5529-push-errors.sh | 2 ++ t/t5546-receive-limits.sh | 2 ++ t/t5547-push-quarantine.sh | 2 ++ t/t5604-clone-reference.sh | 1 + t/t5606-clone-options.sh | 1 + t/t5613-info-alternate.sh | 2 ++ t/t5705-session-id-in-capabilities.sh | 1 + t/t5810-proto-disable-local.sh | 2 ++ t/t5813-proto-disable-ssh.sh | 2 ++ t/t6011-rev-list-with-bad-commit.sh | 1 + t/t6014-rev-list-all.sh | 1 + t/t6021-rev-list-exclude-hidden.sh | 1 + t/t6439-merge-co-error-msgs.sh | 1 + t/t7105-reset-patch.sh | 2 ++ t/t7106-reset-unborn-branch.sh | 2 ++ t/t7107-reset-pathspec-file.sh | 1 + t/t7301-clean-interactive.sh | 1 + t/t7403-submodule-sync.sh | 1 + t/t7409-submodule-detached-work-tree.sh | 1 + t/t7416-submodule-dash-url.sh | 2 ++ t/t7450-bad-git-dotfiles.sh | 2 ++ t/t7701-repack-unpack-unreachable.sh | 1 + 68 files changed, 151 insertions(+), 50 deletions(-) Range-diff against v2: 1: 3de29c6d75f = 1: f5b67f44e2d tests: mark tests as passing with SANITIZE=leak 2: 5036712391d = 2: 88c6b66be3c bundle.c: don't leak the "args" in the "struct child_process" 3: a840a1cb330 ! 3: 8cc8060cd92 commit-graph: use free() instead of UNLEAK() @@ Metadata Author: Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> ## Commit message ## - commit-graph: use free() instead of UNLEAK() + commit-graph: use free_commit_graph() instead of UNLEAK() In 0bfb48e6723 (builtin/commit-graph.c: UNLEAK variables, 2018-10-03) this was made to UNLEAK(), but we can just as easily invoke the 4: c05620cef49 = 4: 765d5cbcf81 clone: use free() instead of UNLEAK() 5: 62af6557760 = 5: 5087fb73286 various: add missing clear_pathspec(), fix leaks 6: 7cea3da9fae = 6: 39cb8aefb58 name-rev: don't xstrdup() an already dup'd string 7: b5978d75c6a = 7: a3f1e800127 repack: fix leaks on error with "goto cleanup" 8: 468615570f4 = 8: f918a6f2adc worktree: fix a trivial leak in prune_worktrees() 9: 8c5c964d872 = 9: 56204806dfd http-backend.c: fix "dir" and "cmd_arg" leaks in cmd_main() 10: fd34c4817f4 = 10: 5355e0fc60b http-backend.c: fix cmd_main() memory leak, refactor reg{exec,free}() 11: f7005f32cc0 = 11: dfb52dbd1c4 commit-graph: fix a parse_options_concat() leak 12: bf0e9bc5fa6 = 12: e44e74dcc58 show-branch: free() allocated "head" before return 13: b157092e8d0 = 13: 6d99fdcc44e builtin/merge.c: always free "struct strbuf msg" 14: bdd2bc9a956 = 14: a3bf3045597 builtin/merge.c: free "&buf" on "Your local changes..." error 15: d5210017cab < -: ----------- connected.c: free(new_pack) in check_connected() 16: 2016b4ddd0b = 15: 7c70bbdebc8 object-file.c: release the "tag" in check_tag() 17: fa2e8a7d297 = 16: 17537e1393e grep.c: refactor free_grep_patterns() 18: 3fcf7054708 = 17: e4bd46a343e grep API: plug memory leaks by freeing "header_list" 19: fa5d657312f = 18: 3e4b12cb623 receive-pack: free() the "ref_name" in "struct command" 20: e5af27134df = 19: d51ed239a8a push: free_refs() the "local_refs" in set_refspecs() -- 2.39.0.1195.gabc92c078c4
