On 23/01/09 06:21PM, Ævar Arnfjörð Bjarmason wrote: > > On Mon, Jan 09 2023, Jacob Abel wrote: > > > On 23/01/09 01:26PM, Ævar Arnfjörð Bjarmason wrote: > >> > >> On Sat, Jan 07 2023, Jacob Abel wrote: > >> > >> > [...] > >> > >> This round looks good to me, except for a small tiny (and new) > >> portability issue that needs fixing: > >> > >> > [...] > >> > >> Good to get rid of this. > >> > >> > [...] > >> > ++ grep -P "fatal:( options)? .* cannot be used together" actual > >> > >> This is the new unportable code, the "-P" option is specific to GNU > >> grep, and here you're relying on the "?" syntax along with other > >> ERE-like syntax. > >> > >> It looks like the minimal fix here is to just change -P to -E, which we > >> can use, you're not using any PCRE-syntax, but just syntax that's part > >> of ERE. > > > > Understood. I have made the change and prepared a new revision already if this > > is all that needs to be changed. I can submit it at any time however I was > > unsure of whether it was considered bad etiquette to submit new revisions so > > close to each other. > > It would be good to have that new revision soon in this case. > > Generally, if you submit a series you're expected to wait to give more > comments time to trickle in. > > But as a series gets more "ready" a re-roll can come sooner, e.g. in > this case where at least I'm fairly confident that this is (knock on > wood) "the last bug". > > So once that version's in Junio can hopefully queue it for graduation to > next soon-ish. OK. That makes sense. In that case I'll get that sent out right now.
