Hi, [culled make-w32, as per explicit request] On Tue, 16 Oct 2007, Eli Zaretskii wrote: > > Date: Tue, 16 Oct 2007 01:56:46 -0400 (EDT) > > From: Daniel Barkalow <barkalow@xxxxxxxxxxxx> > > cc: raa.lkml@xxxxxxxxx, Johannes.Schindelin@xxxxxx, ae@xxxxxx, > > tsuna@xxxxxxxxxxxxx, git@xxxxxxxxxxxxxxx, make-w32@xxxxxxx > > > > Ah, that's helpful. We don't actually care too much about the > > particular info in stat; we just want to know quickly if the file has > > changed, so we can hash only the ones that have been touched and get > > the actual content changes. > > As I wrote in my other message, using native APIs improves performance > by at least a factor of two. Somehow this does not appeal to my "portability is good" side. You know, if we had to do such trickeries for every platform we support, we'd soon be as big as Subversion *cough*. For me, this is the most annoying part about programming Win32. They went out of their way to make it incompatible with everything else, and as a consequence it is a PITA to maintain crossplatform programs. > > The tricky thing is that, while the optimization process is running, > > other programs may be reading the database, so (1) the files that are > > no longer needed, because better-optimized versions are in place, may > > be open in another task > > Is this because another user might be accessing the database, or are > there other popular use cases that cause this? If the former, then this > is not terribly important on Windows, since the situation when more than > one user is logged and actively works is quite rare, basically limited > to some scheduled task (the equivalent of a cron job) running for some > user while another one is logged in interactively. Quite to the contrary. Explorer often accesses files it should not lock. On the machine I test msysGit on, this is the most common reason for a test case to fail: it cannot delete the temporary directory, which _should_ be unused. Indeed, a second after that, it _is_ unused. Ciao, Dscho - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
