"Derrick Stolee via GitGitGadget" <gitgitgadget@xxxxxxxxx> writes:
> + if (!strcmp(subkey, "creationtoken")) {
> + if (sscanf(value, "%"PRIu64, &bundle->creationToken) != 1)
> + warning(_("could not parse bundle list key %s with value '%s'"),
> + "creationToken", value);
> + return 0;
> + }
We tend to avoid sscanf() to parse out integral values, as it is a
bit too permissive to our liking (especially while parsing the
object header), but here it probably is OK, I guess.
> + /**
> + * If the bundle is part of a list with the creationToken
> + * heuristic, then we use this member for sorting the bundles.
> + */
> + uint64_t creationToken;
> };
Is the idea behind the type is that creationTokens, while we leave
up to the bundle providers what the actual values (other than zero)
mean, must be comparable to give them a total order, and uint64
would be a usable type for bundle providers to come up with such
values easily?
Thanks.
