René Scharfe <l.s.r@xxxxxx> writes: > Subject: [PATCH] environ: use git_parse_maybe_bool() for GIT_FLUSH > > Accept textual boolean values like "true" and "false" for GIT_FLUSH by > using git_parse_maybe_bool() to parse the variable's value. Here's > how this changes whether to flush: > > before with this patch > ---------------------- ----------------------- ----------------------- > (unset) if stdin is not a file if stdin is not a file > GIT_FLUSH= no no > GIT_FLUSH=0 no no > GIT_FLUSH=1 yes yes > GIT_FLUSH=false no no > GIT_FLUSH=true no yes > GIT_FLUSH=bogus no if stdin is not a file The above looks easy to grok, but the following caught my eyes. > GIT_FLUSH=10000000000 yes if stdin is not a file Is this because the int is so large that git_parse_signed() notices that it is out of bound (hence "bogus")? > Requested-by: Junio C Hamano <gitster@xxxxxxxxx> > Signed-off-by: René Scharfe <l.s.r@xxxxxx> > --- > Documentation/git.txt | 10 ++++------ > write-or-die.c | 18 +++++++++--------- > 2 files changed, 13 insertions(+), 15 deletions(-) I may have suggested it, but don't think I requested ;-) The patch text looks good. Thanks.
