After joining threads, the handle to the original thread should be closed as it no longer needs to be open. Signed-off-by: Seija Kijin doremylover123@xxxxxxxxx Seija Kijin (2): win32: prepare pthread.c for change by formatting win32: close handles of threads that have been joined compat/win32/pthread.c | 25 ++++++++++++++----------- 1 file changed, 14 insertions(+), 11 deletions(-) base-commit: 2b4f5a4e4bb102ac8d967cea653ed753b608193c Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-1406%2FAtariDreams%2Fjoin-v13 Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-1406/AtariDreams/join-v13 Pull-Request: https://github.com/git/git/pull/1406 Range-diff vs v12: 1: e0cc43efc6c ! 1: 6f89b120641 win32-pthread: prepare pthread.c for change by formatting @@ Metadata Author: Seija Kijin <doremylover123@xxxxxxxxx> ## Commit message ## - win32-pthread: prepare pthread.c for change by formatting + win32: prepare pthread.c for change by formatting - File has been formatted to meet coding guidelines + File has been formatted to meet coding guidelines. Signed-off-by: Seija Kijin <doremylover123@xxxxxxxxx> @@ compat/win32/pthread.c: static unsigned __stdcall win32_start_routine(void *arg) if (!thread->handle) return errno; -@@ compat/win32/pthread.c: int pthread_create(pthread_t *thread, const void *unused, - - int win32_pthread_join(pthread_t *thread, void **value_ptr) +@@ compat/win32/pthread.c: int win32_pthread_join(pthread_t *thread, void **value_ptr) { -- DWORD result = WaitForSingleObject(thread->handle, INFINITE); -- switch (result) { + DWORD result = WaitForSingleObject(thread->handle, INFINITE); + switch (result) { - case WAIT_OBJECT_0: - if (value_ptr) - *value_ptr = thread->arg; @@ compat/win32/pthread.c: int pthread_create(pthread_t *thread, const void *unused - return EINVAL; - default: - return err_win_to_posix(GetLastError()); -+ switch (WaitForSingleObject(thread->handle, INFINITE)) { + case WAIT_OBJECT_0: + if (value_ptr) + *value_ptr = thread->arg; 2: fa5cbfa5e0c = 2: f126d6416d5 win32: close handles of threads that have been joined -- gitgitgadget
