René Scharfe <l.s.r@xxxxxx> writes: > Am 28.12.22 um 19:00 schrieb Ævar Arnfjörð Bjarmason: >> Call clear_pathspec() on the pathspec initialized in >> push_stash(). > > This puzzled me for a while. This patch adds an {0} initializer to the > declaration of the pathspec. I assumed that this is necessary to avoid > giving clear_pathspec() an uninitialized struct. It isn't, though, > because the pathspec is handed to parse_pathspec() first, which > initializes it. So you can safely drop the first hunk. It did mislead me too. I expected that addition of "= { 0 }" was to remove memset('\0') somewhere else, but that is not the case.