On Wed, Dec 21, 2022 at 10:13 PM Eric Sunshine <sunshine@xxxxxxxxxxxxxx> wrote: > > On Wed, Dec 21, 2022 at 3:58 PM Phillip Wood <phillip.wood123@xxxxxxxxx> wrote: > > On 21/12/2022 13:47, Karthik Nayak wrote: > > > Since we use a tree-ish object, the user can pass "--revision > > > HEAD:subdirectory" and all the attributes will be looked up as if > > > subdirectory was the root directory of the repository. > > > > We should be clear in the documentation and option help that --revision > > takes a tree-ish (i.e. --revision=<tree-ish>). Maybe calling the option > > --tree would be clearer. > > If that's the case, shouldn't this be called --source (or some > variation thereof) for consistency[1] with git-restore? > > [1]: https://lore.kernel.org/git/CAPig+cT_xz3m-3kkL_Scf0opNXkikU94kSF46VO8KHkNMWbGzg@xxxxxxxxxxxxxx/ > Let me rename it to source, and we can discuss on the next version if the name suits or not. -- - Karthik
