Am 21.12.22 um 05:46 schrieb Seija Kijin via GitGitGadget: > From: Seija Kijin <doremylover123@xxxxxxxxx> > > After the thread terminates, the handle to the > original thread should be closed. > > This change makes win32_pthread_join POSIX compliant. > > Signed-off-by: Seija Kijin <doremylover123@xxxxxxxxx> > --- > compat/win32/pthread.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/compat/win32/pthread.c b/compat/win32/pthread.c > index 2e7eead42cb..21c705778b6 100644 > --- a/compat/win32/pthread.c > +++ b/compat/win32/pthread.c > @@ -42,10 +42,13 @@ int win32_pthread_join(pthread_t *thread, void **value_ptr) > case WAIT_OBJECT_0: > if (value_ptr) > *value_ptr = thread->arg; > + CloseHandle(thread->handle); > return 0; > case WAIT_ABANDONED: > + CloseHandle(thread->handle); > return EINVAL; > default: > + /* the function failed, so do not detach */ > return err_win_to_posix(GetLastError()); > } > } This patch looks good. It passes the test suite on Windows. Hence: Acked-by: Johannes Sixt <j6t@xxxxxxxx> The follow-up patch in this thread, though, has an incomplete subject line and no motivation. It is not ready to be picked up. -- Hannes
