Re: js/drop-mingw-test-cmp, was Re: What's cooking in git.git (Dec 2022, #03; Sun, 11)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Junio,

On Tue, 13 Dec 2022, Junio C Hamano wrote:

> Johannes Schindelin <Johannes.Schindelin@xxxxxx> writes:
>
> > There is a new iteration available here:
> > https://lore.kernel.org/git/pull.1309.v5.git.1670339267.gitgitgadget@xxxxxxxxx/
>
> Thanks.
>
> IIRC the review comments hinted that MinGW specific test_cmp that
> equates CRLF and LF are no longer needed,

That does not match my understanding. The MSYS2 tools we use in Git for
Windows' SDK (and therefore, in the `win` jobs of our CI runs) are outside
of our control, and have been known to change behavior with regards to
line endings.

If we want to have a robust experience, we will need to continue that
`test_cmp` practice that ignores line endings-only differences.

Ciao,
Johannes




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux