On Tue, Dec 20 2022, Derrick Stolee wrote: > On 12/20/22 7:31 AM, Hubert Jasudowicz wrote: >> This reverts commit aef7d75e5809eda765bbe407c7f8e0f8617f0fd0. >> >> The change breaks git bundle command. Running any subcommand >> results with: >> >> $ git bundle create >> Segmentation fault (core dumped) > > Could you be more specific? I don't think the report can get more specific than (quoting it): $ git bundle create Segmentation fault (core dumped) :) Did you try running it? > We have tests that verify that > these commands work without a segfault. There must be something > different about your environment that makes the segfault occur. We don't have those tests, I submitted an alternate smaller fix in https://lore.kernel.org/git/patch-1.1-2319eb2ddbd-20221220T133941Z-avarab@xxxxxxxxx/ that adds some. I think what you're misrecalling here is probably that we have general tests for running "git <cmd> -h" for all built-in <cmd>, but we don't have any such tests for running sub-commands. And even then, that wouldn't catch this, as it's a bespoke segfault in the bundle code, as it can't handle not getting at least one non-option argument.
