"Sheepolution via GitGitGadget" <gitgitgadget@xxxxxxxxx> writes:
> Subject: Re: [PATCH] Fix word "does" sticking to "not" by adding space
Not incorrect per-se, but the above fails to say a more important
thing---where does the typo appear?
Subject: [PATCH] mingw: fix typo in an error message from ownership check
or something, perhaps.
> From: =?UTF-8?q?Dani=C3=ABl=20Haazen?= <danielhaazen@xxxxxxxxxxx>
Here is where the proposed log message goes, not ...
> Signed-off-by: Daniël Haazen <danielhaazen@xxxxxxxxxxx>
> ---
> git: fix word "does" sticking to "not" in message
>
> When a repository is on a FAT32 file system it will send a message to
> the user explaining they should use git config --global --add
> safe.directory. To prevent a long line in the file the message is made
> up of two string literals. In this change the first literal has a space
> added to it to fix the issue that the last and the first word of the two
> literals stick together like the example image below.
... here.
When a repository is on a FAT32 file system it will send a
message that the path ownership cannot be determined. Fix a
typo in the message.
should be sufficient.
> diff --git a/compat/mingw.c b/compat/mingw.c
> index d614f156df1..af397e68a1d 100644
> --- a/compat/mingw.c
> +++ b/compat/mingw.c
> @@ -2752,7 +2752,7 @@ int is_path_owned_by_current_sid(const char *path, struct strbuf *report)
> /*
> * On FAT32 volumes, ownership is not actually recorded.
> */
> - strbuf_addf(report, "'%s' is on a file system that does"
> + strbuf_addf(report, "'%s' is on a file system that does "
> "not record ownership\n", path);
Thanks for spotting the mistake. Very much appreciated.
