Mathias Krause <minipli@xxxxxxxxxxxxxx> writes: > ... However, from a user's point of view a fall back to > interpreter mode might still be desired in this case, as a failing > 'git grep' is simply not acceptable, IMHO. "git grep" that silently produces a wrong result (by falling back after a problem is detected) would not be acceptable, either. Receiving BADOPTION could be a sign that there is something wrong in the input, not from the end-user but from the code, in which case stopping with BUG() may be a more appropriate? >> I put a BUG() there, we could keep the die(), but >> PCRE2_ERROR_JIT_BADOPTION is really more appropriate as a BUG(), and if >> it starts returning any other codes our use of the API is also in some >> unknown state, so we should also BUG() out. > > Valid points. I'll give others some more time to churn in and if there > are no strong objections, I'll change it like you suggest. Yup, sounds quite sensible.
