Re: [PATCH 0/9] more -Wunused-parameter fixes/annotations

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jeff King <peff@xxxxxxxx> writes:

> This was supposed to just be annotations, but after staring at a few of
> the cases, I think we're better off removing the unused parameters. I've
> floated those ones up to the top of the series.

All looked sensible.  Thanks.
>
>   [1/9]: ls-refs: use repository parameter to iterate refs
>   [2/9]: blob: drop unused parts of parse_blob_buffer()
>   [3/9]: list-objects: drop process_gitlink() function
>   [4/9]: ws: drop unused parameter from ws_blank_line()
>   [5/9]: xdiff: drop unused parameter in def_ff()
>   [6/9]: xdiff: mark unused parameter in xdl_call_hunk_func()
>   [7/9]: diff: mark unused parameters in callbacks
>   [8/9]: list-objects-filter: mark unused parameters in virtual functions
>   [9/9]: userdiff: mark unused parameter in internal callback
>
>  add-interactive.c           |  2 +-
>  apply.c                     |  4 ++--
>  blob.c                      |  3 +--
>  blob.h                      |  3 +--
>  builtin/add.c               |  2 +-
>  builtin/fast-export.c       |  2 +-
>  builtin/merge-tree.c        |  2 +-
>  builtin/merge.c             |  2 +-
>  builtin/rerere.c            |  2 +-
>  builtin/reset.c             |  3 ++-
>  builtin/submodule--helper.c |  2 +-
>  cache.h                     |  2 +-
>  combine-diff.c              |  2 +-
>  diff-lib.c                  |  2 +-
>  diff.c                      | 18 +++++++++---------
>  list-objects-filter.c       | 30 +++++++++++++++---------------
>  list-objects.c              | 33 +--------------------------------
>  ls-refs.c                   |  5 +++--
>  object.c                    |  5 ++---
>  range-diff.c                | 12 ++++++++----
>  ref-filter.c                |  5 +++--
>  refs.c                      |  9 +++++----
>  refs.h                      |  6 ++++--
>  revision.c                  | 25 +++++++++++++++----------
>  submodule.c                 |  2 +-
>  userdiff.c                  |  3 ++-
>  ws.c                        |  2 +-
>  wt-status.c                 |  4 ++--
>  xdiff/xdiffi.c              |  2 +-
>  xdiff/xemit.c               |  4 ++--
>  30 files changed, 90 insertions(+), 108 deletions(-)
>
> -Peff



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux