Jeff King <peff@xxxxxxxx> writes: > On Mon, Dec 12, 2022 at 12:59:55PM -0800, Jonathan Tan wrote: > > > > And possibly put a comment above open_loose_object() that "path" > > > is only guaranteed to point to something sensible when a non-negative > > > value is returned. > > > > Junio made a point that there could, for example, be no path when the > > odb list is empty (maybe in the future) so I don't think this would be > > sufficient. But there is already a comment there pointing to a comment > > in another function that states "path ... (if any)" so this is something > > that callers should already take care of. In my changes, I'll initialize > > it to NULL and whenever I use it, I'll check for non-NULL first. > > If we return a non-negative value, then we opened something, so by > definition, don't we have a path of the thing we opened? Hmm...are you saying "path is guaranteed when there is no error; when there is an error, the caller must check"? If yes, I think we are in agreement. In any case, to make things more concrete, I've just sent a new version [1]. [1] https://lore.kernel.org/git/cover.1670885252.git.jonathantanmy@xxxxxxxxxx/
