On 22/12/12 07:16PM, Ævar Arnfjörð Bjarmason wrote:
> > The following are what I have made for this set of changes (against v4).
> >
> > diff --git a/builtin/worktree.c b/builtin/worktree.c
> > index 8bb1453e0f..38f7a27927 100644
> > --- a/builtin/worktree.c
> > +++ b/builtin/worktree.c
> > @@ -732,12 +732,11 @@ static int add(int ac, const char **av, const char *prefix)
> > } else if (!lookup_commit_reference_by_name(branch)) {
> > advise_if_enabled(ADVICE_WORKTREE_ADD_ORPHAN,
> > "If you meant to create a worktree containing a new orphan branch\n"
> > - "(branch with no commits) for this repository, e.g. '%s',\n"
> > - "you can do so using the --orphan option:\n"
> > + "(branch with no commits) for this repository, you can do so\n"
> > + "using the --orphan option:\n"
> > "\n"
> > - " git worktree add --orphan %s %s\n"
> > - "\n",
> > - new_branch, new_branch, path);
> > + " git worktree add --orphan %s %s\n",
> > + new_branch, path);
>
> Looks good, we'd usually put the "new_branch, path" on the previous line
> (to the extent that it fits within 79 chars.
>
> Also: This string should use _() to mark this for translation.
Done.
