Derrick Stolee via GitGitGadget wrote:
> These patches represent small fixups that came in review from the last
> version of 'ds/bundle-uri-4'. Since it was merged to 'next', these patches
> are forward-fixes on that branch.
>
> Note: I did not include any changes that could be solved by adding an UNUSED
> macro, saving that for Peff and his already-prepared patches in that area.
>
> Thanks, -Stolee
>
> Derrick Stolee (3):
> bundle-uri: drop unused 'uri' parameter
> bundle-uri: advertise based on repo config
> bundle-uri: remove GIT_TEST_BUNDLE_URI env variable
The first two patches (unused arg removal & using repo to get config) are
straightforward fixes for issues mentioned earlier ([1] and [2],
respectively). The last patch replaces the 'GIT_TEST_BUNDLE_URI' environment
variable with globally setting 'transfer.bundleURI' for a subset of the
'lib-bundle-uri-protocol.sh' tests. The comment you added in that file ("The
remaining tests will all assume transfer.bundleURI=true") clearly explains
what you're doing there as a reference for future updates to the tests.
These patches all look good to me. Thanks!
[1] https://lore.kernel.org/git/affbc458-d4f5-525f-d431-5ec1d489afc8@xxxxxxxxxx/
[2] https://lore.kernel.org/git/4d4e02c3-89dc-8372-7e8a-7ec76fdd6f4e@xxxxxxxxxx/
