On 12/7/2022 5:27 PM, Ævar Arnfjörð Bjarmason wrote: > > On Wed, Dec 07 2022, Derrick Stolee via GitGitGadget wrote: > >> From: Derrick Stolee <derrickstolee@xxxxxxxxxx> >> [...] >> +# Given a filename, extract its trailing hash as a hex string >> +test_trailing_hash () { >> + local file="$1" && >> + tail -c $(test_oid rawsz) "$file" | \ >> + test-tool hexdump | \ > > You don't need the "\"'s here. Thanks. >> + sed "s/ //g" >> +} > > At the end of this series we have one test file using this > test_trailing_hash, can't we just add it to t1600-index.sh? I imagine that it would be helpful to access the trailing hash for testing other file formats in the future. It certainly could have helped the incremental commit-graph work, so we could check that the filenames do match the trailing hashes. Thanks, -Stolee