On Thu, Dec 8, 2022 at 7:10 AM Johannes Schindelin <Johannes.Schindelin@xxxxxx> wrote: > On Mon, 5 Dec 2022, Eric Sunshine wrote: > > On Sun, Nov 20, 2022 at 10:00 PM Eric Sunshine via GitGitGadget > > <gitgitgadget@xxxxxxxxx> wrote: > > > The t1509-root-work-tree script started failing earlier this year but went > > > unnoticed because the script is rarely run since it requires setting up a > > > chroot environment or a sacrificial virtual machine. This patch series fixes > > > the failure and makes it a bit easier to run the script repeatedly without > > > it tripping over itself. > > > > Ping? > > Thank you for the ping. I did not have much time for the Git mailing list > as of late (too much Git for Windows stuff going on). > > The patch series looks good to me, with or without the `test_atexit` > change I suggested. Thanks for looking over the series. Taking downstream discussion[1][2] into account regarding test_atexit(), I think I'll let the series stand as-is. In the long run, t1509 may need an overhaul, but the current series is intended to be the minimal possible change (patch [1/3]) to get the script working again, plus very minor "fixes" (patches [2/3] and [3/3]) to make it a bit friendlier for the next person who has to debug a failure in the script. [1]: https://lore.kernel.org/git/221208.86fsdq6nci.gmgdl@xxxxxxxxxxxxxxxxxxx/ [2]: https://lore.kernel.org/git/xmqq5yel18xf.fsf@gitster.g/
