Jeff King <peff@xxxxxxxx> writes: >> > git config trailer.sign.key Signed-off-by >> > git config trailer.sign.cmd \ >> > 'git var GIT_COMMITTER_IDENT | sed "s/>.*/>/";:' >> > git commit --trailer=sign >> > >> > which is only a little more typing than --signoff, but it's not very >> > ergonomic. >> >> It does not look _too_ bad, though. > > What I don't like about it is: > > - the external cmd is complicated and slow. It would be nice if you > could just set trailer.sign.ident=true or something, and it would > use your ident by default if no value is given (and maybe even do > completion similar to "commit --author" if a value is given). Ah, "trailer.sign.value" to use the same value does not exist, and the closest kludge we can use is the .cmd thing? Then it is a shame but it should be easy to correct? > - you have to know to be clever enough to define and use > --trailer=sign. If --signoff didn't exist, that's not too big a > stretch. But since it does, everyone will naturally reach for it > first. We could reimplement --signoff to actually take attention to the "trailer.sign.*" thing, if we wanted to, and that makes it very easy to explain, I guess.
