On Tue, Dec 06, 2022 at 07:53:14PM +0000, Rose via GitGitGadget wrote: > From: Seija <doremylover123@xxxxxxxxx> > > We can avoid having to call memset by calling calloc Who are "we"? Please avoid using first-person pronouns (I and we), since these are ambiguous in context of many entities (individuals/companies) participating in development. Instead, write in imperative mood and passive voice, e.g. "Avoid the need to call memset by allocating with calloc() instead of malloc().". Even then, what are justifications of malloc() -> calloc() conversion other than the described above? > > Signed-off-by: Seija doremylover123@xxxxxxxxx The SoB doesn't look OK. It should have been "Signed-off-by: Your Real Name <yourname@what.domain>". Thanks. -- An old man doll... just what I always wanted! - Clara
Attachment:
signature.asc
Description: PGP signature